Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add health check endpoint #162

Merged
merged 8 commits into from
Oct 10, 2023
Merged

Add health check endpoint #162

merged 8 commits into from
Oct 10, 2023

Conversation

nwarms
Copy link
Collaborator

@nwarms nwarms commented Oct 4, 2023

Changes

Adds an endpoint to check the health of the app using .Net in built health check. Also adds a short test to check the health end point can be reached and is Healthy.

Checklist

  • Deploy this branch to the test environment for manual testing once comments have been resolved and checks have passed
  • Attach this pull request to the appropriate user story in Azure DevOps
  • Update the ADR decision log if needed

@nwarms nwarms temporarily deployed to development October 4, 2023 11:19 — with GitHub Actions Inactive
@nwarms nwarms temporarily deployed to development October 4, 2023 11:22 — with GitHub Actions Inactive
@nwarms nwarms temporarily deployed to development October 4, 2023 11:27 — with GitHub Actions Inactive
@nwarms nwarms temporarily deployed to development October 4, 2023 11:30 — with GitHub Actions Inactive
@nwarms nwarms temporarily deployed to development October 5, 2023 12:05 — with GitHub Actions Inactive
@nwarms nwarms temporarily deployed to development October 5, 2023 12:08 — with GitHub Actions Inactive
dynamictulip
dynamictulip previously approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@dynamictulip dynamictulip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, before merging it in we should ensure that we can make an api request to the endpoint with the desired outcome

@nwarms nwarms temporarily deployed to development October 9, 2023 09:08 — with GitHub Actions Inactive
@nwarms nwarms temporarily deployed to development October 9, 2023 09:11 — with GitHub Actions Inactive
@nwarms nwarms temporarily deployed to development October 9, 2023 10:24 — with GitHub Actions Inactive
@nwarms nwarms temporarily deployed to development October 9, 2023 10:26 — with GitHub Actions Inactive
@nwarms nwarms temporarily deployed to development October 9, 2023 11:11 — with GitHub Actions Inactive
@nwarms nwarms temporarily deployed to development October 9, 2023 11:14 — with GitHub Actions Inactive
@nwarms nwarms requested a review from dynamictulip October 9, 2023 11:37
@nwarms nwarms force-pushed the add-health-check-endpoint branch from b7b8dd4 to f026805 Compare October 9, 2023 14:01
@nwarms nwarms temporarily deployed to development October 9, 2023 14:06 — with GitHub Actions Inactive
@nwarms nwarms temporarily deployed to development October 9, 2023 14:08 — with GitHub Actions Inactive
@nwarms nwarms force-pushed the add-health-check-endpoint branch from f026805 to 8a0d440 Compare October 10, 2023 12:42
@nwarms nwarms temporarily deployed to development October 10, 2023 12:43 — with GitHub Actions Inactive
@nwarms nwarms temporarily deployed to development October 10, 2023 12:45 — with GitHub Actions Inactive
@nwarms nwarms temporarily deployed to test October 10, 2023 12:48 — with GitHub Actions Inactive
@nwarms nwarms temporarily deployed to test October 10, 2023 12:50 — with GitHub Actions Inactive
@nwarms nwarms force-pushed the add-health-check-endpoint branch from 8a0d440 to 4fdb944 Compare October 10, 2023 14:09
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nwarms nwarms temporarily deployed to development October 10, 2023 14:13 — with GitHub Actions Inactive
@nwarms nwarms temporarily deployed to development October 10, 2023 14:15 — with GitHub Actions Inactive
@nwarms nwarms merged commit 3304857 into main Oct 10, 2023
8 checks passed
@nwarms nwarms deleted the add-health-check-endpoint branch October 10, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dynamictulip dynamictulip dynamictulip approved these changes

@lookupdaily lookupdaily Awaiting requested review from lookupdaily

@danielryannimble danielryannimble Awaiting requested review from danielryannimble

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nwarms @dynamictulip